Skip to content

Conversation

@dmorehouse
Copy link

YAML.safe_load with keyword arguments is available since Psych 3.1 [https://github.com/ruby/psych/pull/358, https://github.com/ruby/psych/pull/378], but keyword arguments are mandatory since Psych 4.0 [3].

This is a backwards compatible version of #73. Using docker images, I was able to test this works back to Ruby 1.9.3 (probably before that, I just can't build Ruby < 2 on my machine and Ruby 1.9.3 is the only official Docker image).

Fixes #72

@kiskoza kiskoza mentioned this pull request Jan 2, 2024
@kiskoza
Copy link
Collaborator

kiskoza commented Jan 26, 2024

@bf4 this PR should be merged next to make the CI pass for Ruby 3.1+

@kiskoza kiskoza merged commit a5cc81c into jnunemaker:master Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON failures with Ruby 3.1 / Psych 4.0

2 participants