Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does numpydoc need to be an install_requires dependency? #186

Closed
rly opened this issue Jan 10, 2023 · 3 comments · Fixed by #188 or #190
Closed

Does numpydoc need to be an install_requires dependency? #186

rly opened this issue Jan 10, 2023 · 3 comments · Fixed by #188 or #190

Comments

@rly
Copy link
Contributor

rly commented Jan 10, 2023

I work on a package that uses skan and am trying to reduce the dependencies that are installed. I see that setup.cfg specifies that installing skan requires the numpydoc package:
https://github.com/jni/skan/blob/main/setup.cfg#L54

numpydoc does not seem to be important for using skan. Does it need to be under install_requires? Can it be moved to the docs key of the [options.extras_require] section below?

Interestingly, the version of skan on conda-forge does not require numpydoc:
https://github.com/conda-forge/skan-feedstock/blob/main/recipe/meta.yaml

@jni
Copy link
Owner

jni commented Jan 10, 2023

Oops! Yes that seems to be an oversight. I'm not sure why it went there in the first place rather than [docs]. Would you like to/be able to submit a PR fixing this? Thank you! 🙏

@jni jni closed this as completed in #188 Jan 24, 2023
jni pushed a commit that referenced this issue Jan 24, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix #186
@rly
Copy link
Contributor Author

rly commented Jan 24, 2023

I just looked a little more closely at this and realized that numpydoc does not seem to be used at all. In 2f806e7, the last reference to numpydoc was removed from the codebase. Should it just be removed? I also see that it is not in any of the requirements files: https://github.com/jni/skan/tree/main/requirements

@jni
Copy link
Owner

jni commented Jan 25, 2023

😂 yup! Thank you for spotting all these oversights. 🤦

jni pushed a commit that referenced this issue Jan 25, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fix #186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants