Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add key-in helper #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

AmilKey
Copy link

@AmilKey AmilKey commented Apr 19, 2016

@AmilKey AmilKey changed the title add has key helper add key-in helper Apr 19, 2016
@jmurphyau
Copy link
Owner

Does this work if the object that contains the keys changes?

That was the worry I had with doing helpers on arrays and objects..

I'm not 100% on adding this even if it did work after the objects were updated.. I think I more do like the idea of keeping this library focused on simple a -- b comparisons, rather than a inside b type comparisons.. For those I think maybe an array-truth-helpers and hash-truth-helpers or something might be better..

I'm conscious of the fact that any helper added to this library is then included in every app that uses it.. Since there is no exclusion functionality at the moment there would be no way for a user to not include it in their code..

@AmilKey
Copy link
Author

AmilKey commented Apr 29, 2016

@jmurphyau ok, I agree with you, I think you can close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants