Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Bumps the Go version from 1.24.2 to 1.24.3 across the module, install scripts, Dockerfiles, workflows, and examples to include security and bug fixes from Go 1.24.3.
- Update go.mod to require Go 1.24.3
- Adjust install script and Dockerfiles to fetch Go 1.24.3
- Refresh GitHub workflows and action defaults for Go 1.24.3
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated Go directive to 1.24.3 |
| deploy/lib.sh | Updated install script comment & version var |
| deploy/docker/dockerfiles/Dockerfile-dev-* | Bumped ARG default to Go 1.24.3 |
| .github/workflows/*.yml | Updated GOLANG_VERSION env to 1.24.3 |
| .github/actions/*/action.yml | Updated default golang_version to 1.24.3 |
| .env.example | Bumped GOLANG_VERSION to 1.24.3 |
Comments suppressed due to low confidence (3)
deploy/lib.sh:408
- [nitpick] Consider making the install function version-agnostic (e.g., rename
install_go_24toinstall_go) or accept a version parameter to avoid renaming for each patch bump.
# Install go 1.24.3 from tgz
.github/workflows/build_and_test_pr.yml:8
- [nitpick] The Go version is repeated across multiple workflows and Dockerfiles; consider centralizing it in one config or shared variable to reduce duplication and risk of mismatches.
GOLANG_VERSION: 1.24.3
.env.example:13
- [nitpick] Update project documentation or README to note the new minimum required Go version (1.24.3) so contributors are aware of the bump.
GOLANG_VERSION=1.24.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using golang release
1.24.3which includes some important security fixes:More information in the Go 1.24.3 milestone