Flag to enable the osctrld endpoints

[javuto]

Adding the flag --enable-osctrld to enable the osctrld endpoints in osctrl-tls. By default, they are disabled.

[Copilot]

Pull Request Overview

Adds a new --enable-osctrld flag to toggle the registration of osctrld-related endpoints in the TLS service.

• Introduce Osctrld field in ServiceFlagParams and wire it into CLI flags
• Append initOsctrldFlags to TLS flag initialization
• Conditionally register osctrld handlers in osctrlService based on the flag

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
pkg/config/flags.go	Added Osctrld flag, initOsctrldFlags, and hooked it into InitTLSFlags
cmd/tls/main.go	Wrapped osctrld endpoint handlers behind flagParams.Osctrld with a log message

Comments suppressed due to low confidence (2)

pkg/config/flags.go:69

• [nitpick] Consider renaming Osctrld to EnableOsctrld to clearly indicate it’s a boolean flag and align with other fields like TLSServer and DebugHTTPValues.Enabled.

Osctrld bool

cmd/tls/main.go:297

• No tests were added to verify that osctrld endpoints are registered only when the flag is enabled. Add unit or integration tests to cover both flag-enabled and flag-disabled scenarios.

if flagParams.Osctrld {