Merged
Conversation
javuto
reviewed
Apr 3, 2025
pkg/environments/environments.go
Outdated
| // Environment keeps all TLS Environments | ||
| type Environment struct { | ||
| // EnvironmentManager keeps all TLS Environments | ||
| type EnvironmentManager struct { |
Collaborator
There was a problem hiding this comment.
nit: Maybe the name can be EnvManager to reduce its length
zhuoyuan-liu
commented
Apr 4, 2025
pkg/environments/env-cache.go
Outdated
| func NewEnvCache(envs EnvManager) *EnvCache { | ||
| // Create a new cache with a 10-minute cleanup interval | ||
| envCache := cache.NewMemoryCache( | ||
| cache.WithCleanupInterval[TLSEnvironment](2 * time.Hour), |
Contributor
Author
There was a problem hiding this comment.
This value is currently hardcoded, and I think we need a more robust approach to configuration management. Otherwise, the number of command-line flags will quickly become unmanageable and difficult to maintain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an in-memory cache to store parameters that rarely change, reducing the number of requests to the backend database. However, it should only be used for bounded values—such as the environment and node key—because the cache is currently unbounded and may grow indefinitely, potentially leading to OOMKilled errors.
At this point, the cache has been added for the
environmentvalue only.