Deprecate when parameter of naturaldelta

[carterbox]

Related to #247, but does not close.

Adds deprecation warnings for naturaldelta(..., when) because this parameter does not make sense for a timedelta.

Didn't add test because it seems silly to test for the presence of deprecation warnings that will only be around until the next release.

[codecov-commenter]

Codecov Report

Merging #248 (1f19fea) into master (429e3d8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   97.08%   97.10%   +0.02%     
==========================================
  Files          10       10              
  Lines         685      692       +7     
==========================================
+ Hits          665      672       +7     
  Misses         20       20              

Flag	Coverage Δ
GHA_Ubuntu	95.95% <100.00%> (+0.04%)	⬆️
GHA_Windows	95.66% <100.00%> (+0.04%)	⬆️
GHA_macOS	95.95% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/humanize/time.py	96.49% <100.00%> (+0.11%)	⬆️
tests/test_time.py	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429e3d8...1f19fea. Read the comment docs.

[hugovk]

Thanks, couple of little nits.

[carterbox]

I also want to ask if you actually use Sphinx for you documentation. (Those directives for deprecation are for Sphinx). I seems like the readthedocs page for this repository hasn't been updated in some time. https://humanize.readthedocs.io/en/latest/#

Oh, the docs are hosted at python-humanize.readthedocs.io, but I'm still not sure if y'all are using Sphinx.

[hugovk]

Yep, docs are at https://python-humanize.readthedocs.io which uses MkDocs not Sphinx so it'll just have to be written as plain text.

To build and view docs:

tox -e docs
open site/index.html

[hugovk]

Thank you!