[currency] - fix metricreader export and temporality (open-telemetry#…

…1335) * default metricreader and exporter options Signed-off-by: Pierre Tessier <[email protected]> * default metricreader and exporter options Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Juliano Costa <[email protected]>
jmichalak9 · Jan 19, 2024 · 9d62577 · 9d62577
1 parent 49b3637
commit 9d62577
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,8 @@ release.
   ([#1291](https://github.com/open-telemetry/opentelemetry-demo/pull/1291))
 * [currencyservice] - add package name prefix to `rpc.service` attribute
   ([#1333](https://github.com/open-telemetry/opentelemetry-demo/pull/1333))
+* [currency] fix metric exporter options
+  ([#1335](https://github.com/open-telemetry/opentelemetry-demo/pull/1335))
 
 ## 1.7.2
 

diff --git a/src/currencyservice/src/meter_common.h b/src/currencyservice/src/meter_common.h
@@ -24,15 +24,14 @@ namespace
   {
     // Build MetricExporter
     otlp_exporter::OtlpGrpcMetricExporterOptions otlpOptions;
-
     // Configuration via environment variable not supported yet
-    otlpOptions.aggregation_temporality = otlp_exporter::PreferredAggregationTemporality::kDelta;
+    //otlpOptions.aggregation_temporality = otlp_exporter::PreferredAggregationTemporality::kCumulative;
     auto exporter = otlp_exporter::OtlpGrpcMetricExporterFactory::Create(otlpOptions);
 
     // Build MeterProvider and Reader
     metric_sdk::PeriodicExportingMetricReaderOptions options;
-    options.export_interval_millis = std::chrono::milliseconds(1000);
-    options.export_timeout_millis = std::chrono::milliseconds(500);
+    //options.export_interval_millis = std::chrono::milliseconds(60000);
+    //options.export_timeout_millis = std::chrono::milliseconds(30000);
     std::unique_ptr<metric_sdk::MetricReader> reader{
         new metric_sdk::PeriodicExportingMetricReader(std::move(exporter), options) };
     auto provider = std::shared_ptr<metrics_api::MeterProvider>(new metric_sdk::MeterProvider());