json_pure fix
#36
Merged
json_pure fix
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root Gemfile now only contains documentation and release dependencies. The various /gemfiles/* files now contain a mixture of dependencies.
Simplecov has a direct dependency on the `json` gem which makes it impossible to test without the json gem present. It also forces a newer version (>= 1.8) which also breaks the 1.9.3 tests with and older json version. We can explore having a separate run of the tests to generate coverage, but for now, I'm removing simplecov.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version 2.0.1 of json_pure reverted the support for parsing json literal values. Expanded the check to determine how to deal with json values to not be ruby version specific but to check the capabilities of the JSON library present.
Also expanded travis test coverage to include a mix of dependencies.