Restore support for legacy unquoted string literals #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we definitely want to transition away from unquoted string literals, it seems reasonable to do that over time, similarly to how it was handled in jmespath.py. The reason for doing so, is to allow for a simple upgrade path, where a new version of jmespath.rb can be installed, and the software using it can transition all its configuration to use the new format, and then the jmespath.rb version could be upgraded to not even support these expressions. The tests were copied verbatim from jmespath.py, and are not included in the compliance test suite, so comes with an explicit license, which the compliance test suite does not. JSON doesn't allow for comments, so I'm not sure how to handle the attribution clause of the jmespath.py license
|
Thanks for the fix! I've merged this and it should be part of the 1.3 release shortly. I'm not sure what the best path to deal with the license. I'll talk to @jamesls and see if anything is needed. Given this repo lives in the JMESPath org, it should not be a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we definitely want to transition away from unquoted string literals, it seems reasonable to do that over time, similarly to how it was handled in jmespath.py.
The reason for doing so, is to allow for a simple upgrade path, where a new version of jmespath.rb can be installed, and the software using it can transition all its configuration to use the new format, and then the jmespath.rb version could be upgraded to not even support these expressions.
The tests were copied verbatim from jmespath.py, and are not included in the compliance test suite, so comes with an explicit license, which the compliance test suite does not. JSON doesn't allow for comments, so I'm not sure how to handle the attribution clause of the jmespath.py license