Fix button in form issue #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2015 12:37
<button> can be added into <form>. Add this new feature so robobrowser can deal with <button> tags in <form>
|
+1 on this PR |
According to <https://developer.mozilla.org/nl/docs/Web/HTML/Element/button>: + The type of the button. Possible values are: + submit: The button submits the form data to the server. + This is the default if the attribute is not specified, or if the attribute is dynamically changed to an empty or invalid value. + reset: The button resets all the controls to their initial values. + button: The button has no default behavior. It can have client-side scripts associated with the element's events, which are triggered when the events occur. + menu: The button opens a popup menu defined via its designated <menu> element. So, we can treat the button tag with no type specifed as a submit tag. Thanks Vincent Wagelaar <[email protected]> emailing me about this patch.
fkztw
force-pushed
the
fix_button_in_form_issue
branch
from
eadc471 to
9df767b
Compare
|
flake8 no longer supports Python 2.6 since flake8-3.0.0. https://gitlab.com/pycqa/flake8/issues/187 |
flake8 no longer supports Python 2.6 since flake8-3.0.0.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
<button>tags in<form>.