Skip to content

Updated requirements for pip 6.0+ to include a session #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Updated requirements for pip 6.0+ to include a session #32

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff67df2
Updated requirements for pip 6.0+ to include a session
jsenecal Jan 3, 2015
20f6241
Updated requirements for pip 6.0+
jsenecal Jan 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# -*- coding: utf-8 -*-

import os
import re
import re, uuid
import sys

from setuptools import setup, find_packages
Expand Down Expand Up @@ -35,7 +35,7 @@ def find_version(fname):
history = open('HISTORY.rst').read().replace('.. :changelog:', '')
requirements = [
str(requirement.req)
for requirement in parse_requirements('requirements.txt')
for requirement in parse_requirements('requirements.txt', session=uuid.uuid1())
Copy link

@reversefold reversefold Jan 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using uuid.uuid1() as the session? It should be a pip.download.PipSession().

Copy link
Author

@ghost ghost Jan 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, all I wanted was a unique id to fill in the session variable. It is not used afterwards anyways. but yes pip.download.PipSession() would also work there.

Copy link

@reversefold reversefold Jan 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuid.uuid1() is a bad precedent to set as it will fail if, for any reason, pip tries to actually use it.

]

setup(
Expand Down