Output msgId only when logging ack/fails.

Updated issue apache#2909 to only output the message ID for log messages produced by nextTuple, ack, and fail within SupplierSource and ComplexSource.
jmark99 · Feb 15, 2019 · 2ea536f · 2ea536f
1 parent cdbda41
commit 2ea536f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/heron/api/src/java/org/apache/heron/streamlet/impl/sources/ComplexSource.java b/heron/api/src/java/org/apache/heron/streamlet/impl/sources/ComplexSource.java
@@ -82,7 +82,7 @@ public void nextTuple() {
           collector.emit(new Values(tuple));
         }
         // TODO change logging level
-        LOG.info("Emitting: " + new Values(tuple, msgId));
+        LOG.info("Emitting: [" + msgId + "]");
       }
     }
   }
@@ -100,7 +100,7 @@ public void nextTuple() {
       Values values = new Values(msgIdCache.getIfPresent(mid));
       collector.emit(values, mid);
       // TODO change logging level
-      LOG.info("Re-emit:  [" + values.get(0) + ", " + mid + "]");
+      LOG.info("Re-emit:  [" + mid + "]");
     }
   }
 }
diff --git a/heron/api/src/java/org/apache/heron/streamlet/impl/sources/SupplierSource.java b/heron/api/src/java/org/apache/heron/streamlet/impl/sources/SupplierSource.java
@@ -66,7 +66,7 @@ public void open(Map map, TopologyContext topologyContext, SpoutOutputCollector
       collector.emit(new Values(data));
     }
     // TODO change logging level
-    LOG.info("Emitting: " + new Values(data, msgId));
+    LOG.info("Emitting: [" + msgId + "]");
   }
 
   @Override public void ack(Object mid) {
@@ -82,7 +82,7 @@ public void open(Map map, TopologyContext topologyContext, SpoutOutputCollector
       Values values = new Values(msgIdCache.getIfPresent(mid));
       collector.emit(values, mid);
       // TODO change logging level
-      LOG.info("Re-emit:  [" + values.get(0) + ", " + mid + "]");
+      LOG.info("Re-emit:  [" + mid + "]");
     }
   }
 }