Skip to content

Update telemetry code#2

Merged
jmacd merged 1 commit into
jmacd:jmac/refactor_its_5from
utpilla:utpilla/Update-telemetry-code
Jan 17, 2026
Merged

Update telemetry code#2
jmacd merged 1 commit into
jmacd:jmac/refactor_its_5from
utpilla:utpilla/Update-telemetry-code

Conversation

@utpilla
Copy link
Copy Markdown
Collaborator

@utpilla utpilla commented Jan 17, 2026 •
edited
Loading

Changes

  • Remove into_parts()
  • Remove TelemetryShutdown struct and related code to use InternalTelemetrySystem::shutdown
  • Added biased handling in tokio::select! to prioritize cancellations

@github-actions github-actions Bot added the rust label Jan 17, 2026
@utpilla utpilla requested a review from jmacd January 17, 2026 01:15
jmacd
jmacd reviewed Jan 17, 2026
View reviewed changes
Comment thread rust/otap-dataflow/crates/telemetry/src/collector.rs
// Close immediately
drop(_reporter);
collector.run_collection_loop().await.unwrap();
Arc::new(collector).run_collection_loop().await.unwrap();
Copy link
Copy Markdown
Owner

@jmacd jmacd Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@jmacd jmacd merged commit f55cd20 into jmacd:jmac/refactor_its_5 Jan 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmacd jmacd jmacd left review comments

Assignees

No one assigned

Labels

rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@utpilla @jmacd