Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for google-cloud-sdk renamed to google-cloud-cli #18

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

andreped
Copy link
Contributor

@andreped andreped commented Sep 28, 2023

Fixes #17.

Tried improving the test CI as well, but in the end it did not work, so the only modification in this PR is the renaming of the google-cloud-sdk package.

@andreped
Copy link
Contributor Author

@jlumbroso Could you have a look? The current Action is broken.

@michaelklishin
Copy link

I confirm that currently the Action fails trying to delete google-cloud-sdk, a non-existent package. Unfortunaetly apt remove is not an idempotent command.

@andreped
Copy link
Contributor Author

Package has been renamed. I just changed accordingly to delete the right package and problem is solved.

@jlumbroso
Copy link
Owner

Thanks for your contribution @andreped. I have merged your change with previous changes — as well as tried to account for backwards compatibility with old distros.

Let me know if I broke something, and if so, I will re-open and you can make the appropriate changes.

@jlumbroso jlumbroso merged commit 470d85a into jlumbroso:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google-cloud-sdk renamed to google-cloud-cli
3 participants