Skip to content

Conversation

@jlowin
Copy link
Owner

@jlowin jlowin commented May 8, 2025

resolves test failures in #304

Copilot AI review requested due to automatic review settings May 8, 2025 00:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the mcp dependency to a Git commit that includes the streamable client while adding tests to verify lifespan functionality for both low-level and FastMCP servers.

  • Added new lifespan tests in tests/server/test_lifespan.py for low-level and FastMCP servers.
  • Updated pyproject.toml to use the Git commit of the mcp dependency with an explanatory comment.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/server/test_lifespan.py Introduces two new tests to verify lifespan behavior in different servers.
pyproject.toml Updates mcp dependency configuration to temporarily use a Git commit.

@jlowin jlowin merged commit 2998374 into main May 8, 2025
4 checks passed
@jlowin jlowin deleted the http-pin branch May 8, 2025 00:52
jordicore pushed a commit to jordicore/fastmcp that referenced this pull request Jul 2, 2025
Bump mcp dependency to git commit that includes streamable client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants