Skip to content

fix: Revert build to Maven 3.9.x compatibility #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnodet merged 3 commits into from
Mar 17, 2026
+341 −76
Merged

fix: Revert build to Maven 3.9.x compatibility #1699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aef6dbb
fix: Revert build to Maven 3.9.x compatibility (fixes #1690)
gnodet Mar 17, 2026
d783438
fix: Guard release workflow against SNAPSHOT hint tags
gnodet Mar 17, 2026
b33c819
fix: Clean up mvx command syntax in release workflow
gnodet Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,18 @@ jobs:
- name: Verify tag state
id: version
run: |
version=${GITHUB_REF#refs/tags/}
if [[ "$version" == *-* ]]; then
echo "Tag '$version' is not a release version (contains '-'), skipping"
exit 1
fi
git fetch --tags
echo "All recent tags:"
git tag -l --sort=version:refname | head -5
echo "Current commit: $(git rev-parse HEAD)"
echo "Git describe: $(git describe --tags --always)"
echo "Tag: ${GITHUB_REF#refs/tags/}"
echo "version=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT
echo "Tag: $version"
echo "version=$version" >> $GITHUB_OUTPUT

- name: Setup Java
uses: actions/setup-java@v5
Expand All @@ -63,7 +68,7 @@ jobs:
MAVEN_PASSWORD: ${{ secrets.MAVEN_PASSWORD }}
MVX_USE_SYSTEM_JAVA: true
run: |
./mvx mvn -- -B deploy -Dnjord.autoPublish -Pbundle,javadoc,format-check,sign -s .github/release-settings.xml
./mvx mvn -B deploy -Dnjord.autoPublish -Pbundle,javadoc,format-check,sign -s .github/release-settings.xml

- name: Post release
env:
Expand Down Expand Up @@ -103,7 +108,7 @@ jobs:
exit 1
fi

name=$(./mvx mvn -- -q -DforceStdout --raw-streams help:evaluate -N -Dexpression=project.name)
name=$(./mvx mvn -B -q -DforceStdout --raw-streams help:evaluate -N -Dexpression=project.name)
version=${{ steps.version.outputs.version }}
echo "Creating release \"$name $version\" from tag"
gh release create $version --verify-tag --notes-from-tag --title "$name $version"
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ build.rc

.mvn/wrapper/maven-wrapper.jar
.dependency-reduced-pom.xml
.flattened-pom.xml
1 change: 1 addition & 0 deletions .mvn/maven.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
-Dnisse.source.jgit.dynamicVersion=true
2 changes: 2 additions & 0 deletions .mvn/nisse-translation.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
jgit.dynamicVersion=revision,+fallback
jgit.dateIso8601=nisse.jgit.dateIso8601
2 changes: 1 addition & 1 deletion .mvx/config.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
distribution: "temurin",
},
maven: {
version: "4.0.0-rc-5",
version: "3.9.14",
},
node: {
version: "20",
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ JLine is a Java library for handling console input. It's similar to [GNU Readlin
## Requirements

- **Java 11 or higher**: JLine 4.x requires Java 11 as the minimum runtime version
- **Maven 4.0 or higher**: JLine 4.x requires Maven 4.0+ for building from source
- **Note**: JLine 3.x supports Java 8+ and Maven 3.x+, but JLine 4.x requires Java 11+ and Maven 4.0+
- **Maven 3.9 or higher**: JLine 4.x requires Maven 3.9+ for building from source
- **Note**: JLine 3.x supports Java 8+ and Maven 3.x+, but JLine 4.x requires Java 11+ and Maven 3.9+

## Features

Expand Down
12 changes: 10 additions & 2 deletions builtins/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@
https://opensource.org/licenses/BSD-3-Clause

-->
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

<parent />
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.jline</groupId>
<artifactId>jline-parent</artifactId>
<version>${revision}</version>
</parent>

<artifactId>jline-builtins</artifactId>
<name>JLine Builtins</name>
Expand All @@ -22,9 +28,11 @@

<dependencies>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-reader</artifactId>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-style</artifactId>
</dependency>
<dependency>
Expand Down
11 changes: 9 additions & 2 deletions console-ui/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

<parent />
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.jline</groupId>
<artifactId>jline-parent</artifactId>
<version>${revision}</version>
</parent>

<artifactId>jline-console-ui</artifactId>
<name>JLine Console UI (Deprecated)</name>
Expand All @@ -13,6 +19,7 @@

<dependencies>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-builtins</artifactId>
</dependency>
<dependency>
Expand Down
11 changes: 9 additions & 2 deletions console/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@
https://opensource.org/licenses/BSD-3-Clause

-->
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

<parent />
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.jline</groupId>
<artifactId>jline-parent</artifactId>
<version>${revision}</version>
</parent>

<artifactId>jline-console</artifactId>
<name>JLine Console</name>
Expand All @@ -30,6 +36,7 @@
<artifactId>jline-builtins</artifactId>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-style</artifactId>
</dependency>
<dependency>
Expand Down
17 changes: 15 additions & 2 deletions demo/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@
https://opensource.org/licenses/BSD-3-Clause

-->
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

<parent />
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.jline</groupId>
<artifactId>jline-parent</artifactId>
<version>${revision}</version>
</parent>

<artifactId>jline-demo</artifactId>
<name>JLine Demo</name>
Expand All @@ -22,23 +28,27 @@

<dependencies>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-terminal-ffm</artifactId>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-terminal-jni</artifactId>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-reader</artifactId>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-builtins</artifactId>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-console</artifactId>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-shell</artifactId>
</dependency>
<dependency>
Expand All @@ -58,9 +68,11 @@
<artifactId>jline-remote-telnet</artifactId>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-style</artifactId>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-groovy</artifactId>
</dependency>

Expand Down Expand Up @@ -135,6 +147,7 @@
</dependency>

<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-picocli</artifactId>
</dependency>

Expand Down
11 changes: 9 additions & 2 deletions graal/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@
https://opensource.org/licenses/BSD-3-Clause

-->
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

<parent />
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.jline</groupId>
<artifactId>jline-parent</artifactId>
<version>${revision}</version>
</parent>

<artifactId>jline-graal</artifactId>
<name>JLine Native Demo</name>
Expand All @@ -22,6 +28,7 @@

<dependencies>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-shell</artifactId>
</dependency>

Expand Down
11 changes: 9 additions & 2 deletions groovy/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@
https://opensource.org/licenses/BSD-3-Clause

-->
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

<parent />
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.jline</groupId>
<artifactId>jline-parent</artifactId>
<version>${revision}</version>
</parent>
<artifactId>jline-groovy</artifactId>
<name>JLine Groovy</name>

Expand All @@ -21,6 +27,7 @@

<dependencies>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-console</artifactId>
</dependency>
<dependency>
Expand Down
10 changes: 8 additions & 2 deletions jansi-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@
https://opensource.org/licenses/BSD-3-Clause

-->
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

<parent />
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.jline</groupId>
<artifactId>jline-parent</artifactId>
<version>${revision}</version>
</parent>

<artifactId>jansi-core</artifactId>
<name>Jansi Core</name>
Expand Down
12 changes: 10 additions & 2 deletions jansi/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@
https://opensource.org/licenses/BSD-3-Clause

-->
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

<parent />
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.jline</groupId>
<artifactId>jline-parent</artifactId>
<version>${revision}</version>
</parent>

<artifactId>jansi</artifactId>
<name>Jansi Bundle</name>
Expand All @@ -27,6 +33,7 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-terminal</artifactId>
<scope>test</scope>
</dependency>
Expand All @@ -36,6 +43,7 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jansi-core</artifactId>
<scope>test</scope>
</dependency>
Expand Down
17 changes: 15 additions & 2 deletions jline/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,15 @@
https://opensource.org/licenses/BSD-3-Clause

-->
<project xmlns="http://maven.apache.org/POM/4.1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 https://maven.apache.org/xsd/maven-4.1.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">

<parent />
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>org.jline</groupId>
<artifactId>jline-parent</artifactId>
<version>${revision}</version>
</parent>

<artifactId>jline</artifactId>
<name>JLine Bundle</name>
Expand Down Expand Up @@ -52,6 +58,7 @@
<optional>true</optional>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-terminal</artifactId>
<scope>test</scope>
</dependency>
Expand All @@ -62,10 +69,12 @@
</dependency>

<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-terminal-ffm</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-reader</artifactId>
<scope>test</scope>
</dependency>
Expand All @@ -75,10 +84,12 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-shell</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-console</artifactId>
<scope>test</scope>
</dependency>
Expand All @@ -93,6 +104,7 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jline-style</artifactId>
<scope>test</scope>
</dependency>
Expand All @@ -102,6 +114,7 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jline</groupId>
<artifactId>jansi-core</artifactId>
<scope>test</scope>
</dependency>
Expand Down
Loading