Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add java opts option #36

Merged
merged 1 commit into from
Jul 7, 2023
Merged

add java opts option #36

merged 1 commit into from
Jul 7, 2023

Conversation

ekimber
Copy link

@ekimber ekimber commented Feb 24, 2023

No description provided.

@jlesquembre
Copy link
Owner

Thanks, while I want to add support for java options, I'm not sure if that's the right approach. I want to avoid recompile the derivation just because the java options changed.

Maybe a better approach could be to create a wrapper with JDK_JAVA_OPTIONS: https://docs.oracle.com/en/java/javase/11/tools/java.html

@ekimber
Copy link
Author

ekimber commented Feb 25, 2023

Yes I can understand that you would prefer to do it that way, it is a runtime rather than compile time thing. Though in my use case the options are essential and won't change

@ekimber ekimber closed this Feb 25, 2023
@jlesquembre
Copy link
Owner

I'm reopening it to not forget about it

@jlesquembre jlesquembre reopened this Feb 25, 2023
@jlesquembre
Copy link
Owner

@ekimber sorry for taking that long to address this. I'm merging it, it's nice to have that option available, we can optimize it in another PR

@jlesquembre jlesquembre merged commit a05c2d5 into jlesquembre:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants