Repository navigation
WORKING: Fix split CWD inheritance and bash job spam #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,170 @@ | ||
| #!/usr/bin/env python3 | ||
| """ | ||
| End-to-end test for split CWD inheritance. | ||
|
|
||
| Verifies that new split panes and new workspace tabs inherit the current | ||
| working directory from the source terminal. | ||
|
|
||
| Requires: | ||
| - cmux running with allowAll socket mode | ||
| - bash shell integration sourced (cmux-bash-integration.bash) | ||
|
|
||
| Run with a tagged instance: | ||
| CMUX_TAG=<tag> python3 tests/test_split_cwd_inheritance.py | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import os | ||
| import sys | ||
| import time | ||
| from pathlib import Path | ||
|
|
||
| sys.path.insert(0, os.path.dirname(os.path.abspath(__file__))) | ||
|
|
||
| from cmux import cmux, cmuxError # noqa: E402 | ||
|
|
||
|
|
||
| def _parse_sidebar_state(text: str) -> dict[str, str]: | ||
| data: dict[str, str] = {} | ||
| for raw in (text or "").splitlines(): | ||
| line = raw.rstrip("\n") | ||
| if not line or line.startswith(" "): | ||
| continue | ||
| if "=" not in line: | ||
| continue | ||
| k, v = line.split("=", 1) | ||
| data[k.strip()] = v.strip() | ||
| return data | ||
|
|
||
|
|
||
| def _wait_for(predicate, timeout: float, interval: float, label: str): | ||
| start = time.time() | ||
| last_error: Exception | None = None | ||
| while time.time() - start < timeout: | ||
| try: | ||
| value = predicate() | ||
| if value: | ||
| return value | ||
| except Exception as e: | ||
| last_error = e | ||
| time.sleep(interval) | ||
| extra = "" | ||
| if last_error is not None: | ||
| extra = f" Last error: {last_error}" | ||
| raise AssertionError(f"Timed out waiting for {label}.{extra}") | ||
|
|
||
|
|
||
| def _wait_for_focused_cwd( | ||
| client: cmux, | ||
| expected: str, | ||
| timeout: float = 12.0, | ||
| ) -> dict[str, str]: | ||
| def pred(): | ||
| state = _parse_sidebar_state(client.sidebar_state()) | ||
| cwd = state.get("focused_cwd", "") | ||
| return state if cwd == expected else None | ||
| return _wait_for(pred, timeout=timeout, interval=0.3, label=f"focused_cwd={expected!r}") | ||
|
|
||
|
|
||
| def _send_cd_and_wait( | ||
| client: cmux, | ||
| target: str, | ||
| timeout: float = 12.0, | ||
| ) -> dict[str, str]: | ||
| """cd to target and wait for sidebar focused_cwd to reflect it.""" | ||
| client.send(f"cd {target}\n") | ||
| return _wait_for_focused_cwd(client, target, timeout=timeout) | ||
|
|
||
|
|
||
| def main() -> int: | ||
| tag = os.environ.get("CMUX_TAG", "") | ||
|
|
||
| socket_path = None | ||
| if tag: | ||
| socket_path = f"/tmp/cmux-debug-{tag}.sock" | ||
| client = cmux(socket_path=socket_path) | ||
| client.connect() | ||
|
|
||
| # Use resolved paths to avoid /tmp -> /private/tmp symlink mismatch on macOS | ||
| test_dir_a = str(Path("/tmp/cmux_split_cwd_test_a").resolve()) | ||
| test_dir_b = str(Path("/tmp/cmux_split_cwd_test_b").resolve()) | ||
| os.makedirs(test_dir_a, exist_ok=True) | ||
| os.makedirs(test_dir_b, exist_ok=True) | ||
|
|
||
| passed = 0 | ||
| failed = 0 | ||
|
|
||
| def check(name: str, condition: bool, detail: str = ""): | ||
| nonlocal passed, failed | ||
| if condition: | ||
| print(f" PASS {name}") | ||
| passed += 1 | ||
| else: | ||
| print(f" FAIL {name}{': ' + detail if detail else ''}") | ||
| failed += 1 | ||
|
|
||
| print("=== Split CWD Inheritance Tests ===") | ||
|
|
||
| # --- Setup: cd to test_dir_a in workspace 1 --- | ||
| print(" [setup] cd to test_dir_a and wait for shell integration...") | ||
| _send_cd_and_wait(client, test_dir_a) | ||
| state = _parse_sidebar_state(client.sidebar_state()) | ||
| check("setup: focused_cwd is test_dir_a", state.get("focused_cwd") == test_dir_a, | ||
| f"got {state.get('focused_cwd')!r}") | ||
|
|
||
| # --- Test 1: New split inherits test_dir_a --- | ||
| print(" [test1] creating right split from test_dir_a...") | ||
| split_result = client.new_split("right") | ||
| check("split created", bool(split_result)) | ||
|
|
||
| # Wait for the new pane's shell to start and report cwd. | ||
| # The split should inherit test_dir_a from the source pane. | ||
| time.sleep(4) # wait for new bash to start + run PROMPT_COMMAND | ||
|
Comment on lines
+130
to
+137
|
||
|
|
||
| # Use report_pwd to manually seed the new pane's cwd if shell integration | ||
| # hasn't fired yet (macOS /bin/bash can be slow). | ||
| # Instead, just wait for sidebar to converge. | ||
| try: | ||
| state = _wait_for_focused_cwd(client, test_dir_a, timeout=15.0) | ||
| check("test1: split inherited test_dir_a", True) | ||
| except AssertionError as e: | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| # Check what we got instead | ||
| state = _parse_sidebar_state(client.sidebar_state()) | ||
| check("test1: split inherited test_dir_a", False, | ||
| f"focused_cwd={state.get('focused_cwd')!r}") | ||
|
|
||
| # --- Test 2: New workspace tab inherits CWD --- | ||
| # First cd to test_dir_b so we have a different dir to inherit | ||
| print(" [test2] cd to test_dir_b, then creating new workspace tab...") | ||
| _send_cd_and_wait(client, test_dir_b) | ||
|
|
||
| tab_result = client.new_tab() | ||
| check("new tab created", bool(tab_result)) | ||
|
|
||
| # New workspace should inherit test_dir_b from the previous workspace | ||
| time.sleep(4) | ||
| try: | ||
| state = _wait_for_focused_cwd(client, test_dir_b, timeout=15.0) | ||
| check("test2: new workspace inherited test_dir_b", True) | ||
|
Comment on lines
+153
to
+178
|
||
| except AssertionError as e: | ||
| state = _parse_sidebar_state(client.sidebar_state()) | ||
| check("test2: new workspace inherited test_dir_b", False, | ||
| f"focused_cwd={state.get('focused_cwd')!r}") | ||
|
|
||
| print(f"\n{passed} passed, {failed} failed") | ||
|
|
||
| client.close() | ||
|
|
||
| # Cleanup | ||
| for d in [test_dir_a, test_dir_b]: | ||
| try: | ||
| os.rmdir(d) | ||
| except OSError: | ||
| pass | ||
|
|
||
| return 1 if failed else 0 | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| sys.exit(main()) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: jleechanorg/cmux
Length of output: 97
🏁 Script executed:
Repository: jleechanorg/cmux
Length of output: 99
🏁 Script executed:
Repository: jleechanorg/cmux
Length of output: 3967
Use isolated temp dirs and guaranteed teardown for test reliability.
Lines 90–91 use hardcoded
/tmppaths that collide across concurrent test runs. More critically, if any operation before line 157 fails (e.g., in_send_cd_and_wait,_wait_for_focused_cwd, orclient.new_split()), bothclient.close()and directory cleanup are skipped, leaking resources. Wrap the entire test logic in try/finally to guarantee teardown, and usetempfile.TemporaryDirectoryfor isolation. Also remove the unused exception variables at lines 131 and 150.Proposed fix
🧰 Tools
🪛 Ruff (0.15.2)
[error] 85-85: Probable insecure usage of temporary file or directory: "/tmp/cmux-debug-"
(S108)
[error] 90-90: Probable insecure usage of temporary file or directory: "/tmp/cmux_split_cwd_test_a"
(S108)
[error] 91-91: Probable insecure usage of temporary file or directory: "/tmp/cmux_split_cwd_test_b"
(S108)
🤖 Prompt for AI Agents