Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fastify adapter #177

Merged
merged 15 commits into from
May 24, 2023
Merged

Feat: Fastify adapter #177

merged 15 commits into from
May 24, 2023

Conversation

jlalmes
Copy link
Owner

@jlalmes jlalmes commented Nov 27, 2022

No description provided.

ckt1031
ckt1031 previously approved these changes Jan 11, 2023
SeanCassiere
SeanCassiere previously approved these changes Jan 31, 2023
Copy link
Collaborator

@SeanCassiere SeanCassiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how you resolve the package-lock stuff, but with local testing it works.

@NeilTheFisher
Copy link
Contributor

This can be merged into here, then from here into master.

#254

Should I have done it directly into master?

@NeilTheFisher
Copy link
Contributor

Here are the commands I ran to fix it:
gh pr checkout 177 && git fetch origin master && git merge origin/master
rm package-lock.json
manually merged dependencies in package.json
npm i --package-lock-only

final testing:
npm i && npm run test

@nahtnam
Copy link

nahtnam commented Feb 14, 2023

Would love to use this! Anything blocking merge and release?

@ghost
Copy link

ghost commented Mar 7, 2023

Hi guys, is there anything that needs doing before this can be merged? 🙂

@Asher-JH
Copy link

Would be great to use this soon, anything blocking the merge still?

@Mikaleb
Copy link

Mikaleb commented Mar 28, 2023

Nothing new ?

@NeilTheFisher
Copy link
Contributor

Still waiting for my pr to be accepted😴

In the meantime, you could just take this file from the pr and put it in your project to get the adapter working.

@productdevbook
Copy link

when pr merge ?

@joshuaja
Copy link

joshuaja commented May 8, 2023

@jlalmes what's the ETA on the release for this? I could definitely use this in my Fastify project.

Copy link
Owner Author

@jlalmes jlalmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you to all contributors for pushing this PR over the line. Sorry for the delay in getting it merged!

@jlalmes jlalmes merged commit b592734 into master May 24, 2023
@jlalmes
Copy link
Owner Author

jlalmes commented May 24, 2023

Available in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants