Skip to content

Prepare for Makie 0.22 / GeometryBasics 0.5#61

Merged
SimonDanisch merged 4 commits into
jkrumbiegel:masterfrom
ffreyer:ff/GeometryBasic_refactor
Nov 19, 2024
Merged

Prepare for Makie 0.22 / GeometryBasics 0.5#61
SimonDanisch merged 4 commits into
jkrumbiegel:masterfrom
ffreyer:ff/GeometryBasic_refactor

Conversation

@ffreyer
Copy link
Copy Markdown
Contributor

@ffreyer ffreyer commented Oct 14, 2024

If this only relies on Point, Vec and Rect2 this should be fine as a patch Version. If Rect3 is used we need to be a bit careful because coordinates changed (no duplication).

@jkrumbiegel
Copy link
Copy Markdown
Owner

No 3d boundingboxes here, so should be fine

@jkrumbiegel
Copy link
Copy Markdown
Owner

But CI didn't actually run with 0.5, but with 0.4.11

@ffreyer
Copy link
Copy Markdown
Contributor Author

ffreyer commented Oct 14, 2024

Yea 0.5 doesn't exist yet

@SimonDanisch SimonDanisch merged commit 2e692ab into jkrumbiegel:master Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants