Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing namespaces #47

Merged

Conversation

ordovicia
Copy link
Contributor

@ordovicia ordovicia commented Sep 13, 2023

Some namespaced resources created by amazon-eks-pod-identity-webhook Helm chart are missing .metadata.namespace fields.
This PR fixes it.

Signed-off-by: Hidehito Yabuuchi <[email protected]>
@jkroepke
Copy link
Owner

hi., please take note of the failing lint job, thanks

@jmrr
Copy link

jmrr commented Sep 19, 2023

Hi, is this going to be merged and a new chart released?

@ordovicia
Copy link
Contributor Author

@jkroepke Thank you. I bumped the chart version.

@jkroepke
Copy link
Owner

Hi, is this going to be merged and a new chart released?

If actions are green, yes. Each PR releases a new version by default.

Copy link
Owner

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jkroepke jkroepke merged commit ea310eb into jkroepke:main Sep 19, 2023
2 checks passed
@ordovicia ordovicia deleted the amazon-eks-pod-identity-webhook-fix-namespace branch September 20, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants