abort with error on empty HEADER name #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotlinski
reviewed
May 31, 2023
jkotlinski
reviewed
May 31, 2023
CHANGELOG.md
Outdated
| - EVALUATE now accepts multi-line strings. | ||
| - ( refills to accept multi-line comments when parsing EVALUATE strings. | ||
| - CHAR, HEADER and other parsing words no longer do REFILL on missing text. | ||
| - Defining words based on HEADER instead abort with an error. |
There was a problem hiding this comment.
These two lines should probably be joined.
There was a problem hiding this comment.
How about putting "CHAR doesn't REFILL" back where it was and just having the note about "HEADER etc ABORTs" be separate?
There was a problem hiding this comment.
I do not like my original wording.
How about...
- CHAR will no longer REFILL when reaching the end of input buffer.
- Word-creating words will now abort with an error when an unexpected end of input buffer results in an empty word name.
Also moved W2 code up to not repeat the INX instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion.