Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add undo/redo to webapp #65

Open
5 tasks
jkomoros opened this issue Sep 19, 2023 · 0 comments
Open
5 tasks

Add undo/redo to webapp #65

jkomoros opened this issue Sep 19, 2023 · 0 comments

Comments

@jkomoros
Copy link
Owner

Related to #6.

Some way to support undo/redo in the app.

Every operation that modifies any packets (create, delete, change) should go on a state stack. Literally push a new item onto .packets and have a currentPacketVersion which stays at 0 when it's at head, and is non-zero when it's not.

Pass into packet-editor canUndo and canRedo.

  • Make state.data.versionedPackets be an object with a packets array, and have getPacket know how to handle it
  • Add a state.data.versionedPacket.currentVersion= 0
  • Add a pushVersion(versionedState, newVersion : packet)
  • When doing an action that modifies packets, use pushVersion
  • Add a redo/undo functionality
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
Add a bunch of undo utility functions.
4ffcbfb 
Not used anywhere yet, and not exercised, but seems like it should work?

Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
state --> version in undoable utility functions.
a056ea5 
Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
Add initialVersion utility function.
7115170 
Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
BIG COMMIT. Update the data model to use UndoableState for packets.
e2a8a01 
This requires a lot of surgery on reducers/data.

I THINK everything seems to mostly work.

Note that this does NOT change the peristed data model, just the data model in memory.

There are currently no affordances to undo or redo, although versions are available in memory.

Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
Add undo/redo events.
7690da3 
Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
Define UNDO/REDO actions.
c1eafd4 
Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
Add selectMayUndo/Redo.
e97c629 
Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
Add undo/redo action creators and reducers.
94535e4 
Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
main-view listens for undo/redo events.
1638b03 
Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
main-view selects mayUndo/mayRedo.
a43742e 
Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
packet-editor takes mayUndo/mayRedo and renders buttons that when cli…
9280f56 
…cked issue that event.

Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
Hook undo/redo from main-view into packet-editor.
7613fa5 
This actually activates undoing and redoing in practice, and it appears to roughly work.

Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
packet-edtiro allows undo/redo shortcuts to be passed.
3d19402 
Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
main-view hooks undo/redo keyboard events.
effd1bb 
Part of #65.
jkomoros added a commit that referenced this issue Sep 20, 2023
@jkomoros
Remove "This action cannot be undone" warnings because it's now undoa…
5ce71e5 
…ble.

Part of #65.
@jkomoros jkomoros mentioned this issue Sep 21, 2023
Open
2 tasks
jkomoros added a commit that referenced this issue Sep 21, 2023
@jkomoros
Make packets part of a versioned meta-object.
440187f 
This will allow us to version other properties on the undo stack, in particular the environment.

Part of #65. Part of #6.
jkomoros added a commit that referenced this issue Sep 21, 2023
@jkomoros
Get rid of a number of confusingly named duplicative currentVersionSt…
9c54f53 
…ate and currentPackets.

These were in different arms of the switch statement.

Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 21, 2023
@jkomoros
Corrected a non-exercised bug in setPacketsOfType.
ad54247 
Both branches should have copied the existing state.

There was no revealed bug yet because only packets is versioned, but that will soon change.

This is just clearer in intent.

Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 21, 2023
@jkomoros
Add environment to versioned state.
3625549 
This means changes to environment are undoable.

Part of #65. Part of #6.
jkomoros added a commit that referenced this issue Sep 21, 2023
@jkomoros
Stop confirming for environment key delete, now that it's undoable.
f14edb4 
Part of #65. Part of #6.
jkomoros added a commit that referenced this issue Sep 22, 2023
@jkomoros
undo state grows a notion of action description.
381086d 
This is user-visible context for what the action is, that can be shown to a user to let them know what
action will be undone/redone.

Not yet shown to user, but all versioned actions now have a coherent description.

Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 22, 2023
@jkomoros
Define undoVersionDescription and redoVersionDescription.
939153c 
Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 22, 2023
@jkomoros
Wire through undoDescription and redoDescription into UI.
171913a 
The redoDescription message is a bit off, conceptually.

Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 22, 2023
@jkomoros
Fix it so redo message is now the correct index.
9fe3d8b 
Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 22, 2023
@jkomoros
Update the redo/undo messages to use 'Undo '/ 'Redo ' prefixes.
6519d91 
This describes what the action will do.

Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 22, 2023
@jkomoros
Fix a bug where loadEnvironment didn't reset history.
3817a8b 
Before, there was an undo state at the very beginning for no reason.

Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 22, 2023
@jkomoros
Make it so environment change messages describe the key/value/operati…
831dfd8 
…on that was performed.

Previously they just mentioned the environment was changed.

Part of #65. Part of #6.
jkomoros added a commit that referenced this issue Sep 23, 2023
@jkomoros
Make sure that undo/redo verify that a valid seed/packet is selected.
fa7283a 
Before, if you undid a create_packet or _seed action you might get a non-existent seed/packet.

Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 23, 2023
@jkomoros
Make secret keys undo state use the secret value.
2e64157 
Part of #6. Part of #65.
jkomoros added a commit that referenced this issue Sep 23, 2023
@jkomoros
The undo/redo message for seed property handles Objects better.
cbb466d 
Part of #6. Part of #65.
@jkomoros jkomoros mentioned this issue Oct 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkomoros