Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make template json extraction work #59

Open
jkomoros opened this issue Jul 22, 2023 · 0 comments
Open

Make template json extraction work #59

jkomoros opened this issue Jul 22, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jkomoros
Copy link
Owner

The json modifier for template extraction currently doens't work for JSON that has sub-objects

For example, changing the test json modifier full text multi-line to :

{
	"a": 1,
	"b":[
		2,
		3
	],
	"c": {
		"a": true
	}
}

Fails, because of the sub-object. The normal way of doing this is to use recursive match patterns, which arent' supported in javascript. This makes the whole "extract JSON" using the current Regex-based template matching pipeline not viable...

The only fix I see is to change the whole template extraction pipeline to not rely on regexes (or rather, to have a higher-level construct that might use regexes for pieces, but for json extraction doesn't)

Originally captured in #17.

@jkomoros jkomoros added the bug Something isn't working label Jul 22, 2023
jkomoros added a commit that referenced this issue Jul 22, 2023
This is effectively a workaround for json template extraction being broken (#59).

Part of #45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant