Senior Design Project #102
Conversation
…nd and doesn't diminish Karma
Converted the Procedures doc and Test-Plan to docs/todo/ directory in a more parseable format. The content for these can then be later integrated in with the project as entries in the change log and existing documentation. The out/ directory was removed since it looked like it was just generated from jsdoc and had no content. The added files to the bin/ directory were also removed since they are generated.
This uses a locally hosted click sound that meets license requirements. Will still need to add the attribution details to the credits page.
| flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics | ||
| - name: Test with pytest | ||
| run: | | ||
| python -m unittest |
There was a problem hiding this comment.
Well, having this run every time on changes to develop would be a good idea. That will definitely help with keeping the unit tests up to date. I might temporarily disable this action until those tests have been cleaned up.
| @@ -28,7 +28,7 @@ shift "$((OPTIND-1))"; | |||
|
|
|||
| # Defaults | |||
| SECURE_COOKIE_SECRET="chocolate chip" | |||
| MUPPET_CHARACTER="rizzo" | |||
| MUPPET_CHARACTER="pepethekingprawn" | |||
There was a problem hiding this comment.
We'll need to add a picture of this character to the site somewhere. Maybe it could be an easter egg.
bin/create_dot_env.sh
Outdated
| if [ -n "${NEW_PUZZLE_CONTRIB}" ]; then | ||
| MUPPET_CHARACTER=${NEW_PUZZLE_CONTRIB} | ||
| fi | ||
| #if [ -n "${NEW_PUZZLE_CONTRIB}" ]; then |
There was a problem hiding this comment.
This can be uncommented. I've fixed the issue.
pyvenv.cfg
Outdated
| @@ -0,0 +1,4 @@ | |||
| home = /usr/bin | |||
There was a problem hiding this comment.
Not sure if this is needed. The other PR I did on your repo I remove it.
| @@ -11,3 +11,18 @@ | |||
| line-height: 1; | |||
| vertical-align: middle; | |||
| } | |||
| .pm-PuzzleLatency-value-green { | |||
There was a problem hiding this comment.
This looks good and it works. Thanks!
I might change it a bit in the future to use the design tokens and get the colors and such from there.
| @@ -358,6 +362,25 @@ customElements.define( | |||
| ); | |||
| this.draggedPieceID = null; | |||
| } | |||
| document.addEventListener("keydown", (event) => { | |||
There was a problem hiding this comment.
A few issues with this one like it was mentioned in the Procedures doc. I might temporarily disable this feature before pushing it live until those can be resolved.
| @@ -454,6 +496,8 @@ customElements.define( | |||
| if ($_piece !== null && karmaData.karmaChange) { | |||
| if (karmaData.karmaChange > 0) { | |||
| $_piece.classList.add("is-up"); | |||
| var audio = new Audio("https://www.fesliyanstudios.com/play-mp3/387"); | |||
There was a problem hiding this comment.
I changed this to use a sound file that had a compatible license to re-use. See the PR I made on your repo.
| @@ -0,0 +1,41 @@ | |||
| import "./puzzle-time.css"; | |||
There was a problem hiding this comment.
This works and I like it. I think this is a good start and could be changed to persist the time a player has spent on a puzzle in future iterations.
| full administrative control over this puzzle. These can be gained by donating to the website. | ||
| Please click the link below to purchase a puzzle instance!</em> | ||
| </p> | ||
| <a href="http://puzzle.massive.xyz/d/buy-stuff/">Buy Instance Slot</a> |
There was a problem hiding this comment.
This page has actually changed to be more contribution focused. I can reword the purchase part and change it later.
Remove unneeded files
Switch piece click sound
We were able to tackle a few of the issues that you posted. We have those documented in the readme