Deterministic promise resolution #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlespiau
force-pushed
the
2019-03-05-deterministic-promise-resolution
branch
2 times, most recently
from
1d5c6b0 to
937534b
Compare
We want the js author to be able to rely on deterministic order of promise resolution to avoid surprises and generate non-determinitic configuration. We do this by making the order of promise resolution be the same as promise resolution, serializing the deferred goroutines before they re-enter v8 to resolve the promises. Fixes: #110
dlespiau
force-pushed
the
2019-03-05-deterministic-promise-resolution
branch
from
937534b to
80dabb3
Compare
|
Elegant. |
squaremo
approved these changes
Mar 6, 2019
We the info capturing i in the loop works (because of the block scoping from let), we can refine a bit the test, also removing the unnecessary encoding argument to std.read. I tested it with a previous version of jk and the test still shows the "random" behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the js author to be able to rely on deterministic order of promise resolution to avoid surprises and generate non-determinitic configuration.
We do this by making the order of promise resolution be the same as promise creation, serializing the deferred goroutines before they re-enter v8 to resolve the promises.
Fixes: #110