Stubbed nil values for the describe instance calls. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default stub returns non-empty strings for all possible string values. This causes the next token that trigger paging to appear like there is a next response. I updated your stubbs to use nil next tokens to avoid this issue. Please feel free to open this as an issue against aws/aws-sdk-ruby as this is a poor default experience.
jkanywhere
added a commit
that referenced
this pull request
May 2, 2015
Fix broken tests by using `nil` next tokens to avoid erroneous paging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default stub returns non-empty strings for all possible string values. This causes the next token that trigger paging to appear like there is a next response. These changes allow the tests to pass.
I updated your stubs to use
nilnext tokens to avoid this issue. Please feel free to open this as an issue against aws/aws-sdk-ruby as this is a poor default experience.