Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update actions/checkout in GitHub Actions to v3 #30

Merged
merged 1 commit into from
Jun 17, 2022
Merged

update actions/checkout in GitHub Actions to v3 #30

merged 1 commit into from
Jun 17, 2022

Conversation

striezel
Copy link
Contributor

Updates the actions/checkout actions used in the GitHub Actions workflow to its newest version.

Changes in actions/checkout can be seen here: https://github.com/actions/checkout/blob/main/CHANGELOG.md

As far as I can tell this should be backwards compatible, so I do not expect any breakage.

@striezel
Copy link
Contributor Author

It looks like the cross-compilation tests that are failing here only triggered on pull requests but not by normal commits on the master branch. So I guess they may have been broken even before this PR and it just was not noticed before this PR, because those tests do not run on normal commits.

@jk-jeon
Is this a known issue? #11 looks like it could be.

jk-jeon added a commit that referenced this pull request Jun 17, 2022
@jk-jeon
Copy link
Owner

jk-jeon commented Jun 17, 2022

Thanks a lot for the PR. I'm trying to looking at it. The compilation issue is an easy one, but the test failure is something I need to investigate.

It's weird. It seems all tests up to verify_compressed_cache runs successfully. verify_compressed_cache itself also seems to run without any issue I believe, as there is nothing done after printing the message "Verification succeeded. No error detected.". The next test I believe is supposed to be verify_magic_division, but the very first thing it does is to print a message, but there is nothing shown in the log...

@jk-jeon
Copy link
Owner

jk-jeon commented Jun 17, 2022

I'm pretty sure the problem is not in this PR so let's accept it first anyway. Thanks again!

@jk-jeon jk-jeon merged commit 5defa08 into jk-jeon:master Jun 17, 2022
@jk-jeon
Copy link
Owner

jk-jeon commented Jun 17, 2022

Okay. It turned out to be because of a wrong build target name that does not exist anymore. It was not a bug in the source. Thanks!

@striezel
Copy link
Contributor Author

Thank you for taking the time to investigate and clearing that up. :)

@striezel striezel deleted the gh-action-update branch June 18, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants