Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should unsubscribe drain the channel? #12

Open
flowchartsman opened this issue Apr 24, 2015 · 1 comment
Open

Should unsubscribe drain the channel? #12

flowchartsman opened this issue Apr 24, 2015 · 1 comment

Comments

@flowchartsman
Copy link

From looking at the code, it looks as if the subscription readloop goroutine would block if the buffer fills up and then the client unsubscribes, leaving the channel and associated goroutine resources hanging around. Should unsubscribe drain sub.C?

@jjeffery
Copy link
Owner

jjeffery commented May 4, 2015

@alaska Good question.This would be a good scenario to write a unit test for.

jjeffery added a commit that referenced this issue Sep 11, 2016
check subscription completed status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants