Draft
Conversation
91e00f2 to
49ae258
Compare
49ae258 to
2a8b397
Compare
jja725
added a commit
that referenced
this pull request
Mar 19, 2026
- #1: getLatestVersion now uses cache instead of opening throwaway Dataset - #2: Add bounds check for version > Integer.MAX_VALUE before intValue() - #3: Add thread-safety documentation for cached Dataset objects - prestodb#4: Add requireNonNull for tablePath and namespaceHolder in FragmentScannerFactory - prestodb#5: Remove dead code openDatasetDirect() - prestodb#6: Remove dead code getOptionalDatasetVersion() - prestodb#7: Remove premature userIdentity parameter from cache key - prestodb#8: Make getReadOptions() private (only used internally) - prestodb#9: Tests now use versioned table handle from getTableHandle() - prestodb#10: Add @AfterMethod with namespaceHolder.shutdown() to prevent resource leaks - prestodb#12: Use explicit invalidateAll(keys) instead of removeIf on asMap()
jja725
added a commit
that referenced
this pull request
Mar 19, 2026
- #1: Add javadoc noting eventual consistency contract for getLatestVersion - prestodb#4: Fix RST table column alignment for cache properties - prestodb#5: Use toImmutableList() instead of Collectors.toList() per Presto convention
jja725
added a commit
that referenced
this pull request
Mar 26, 2026
- #1: Parenthesize multi-part range expressions for unambiguous precedence - #2: values.isNone() + !isNullAllowed() now returns "false" instead of empty - #3/prestodb#6/prestodb#7: Use extractFilterColumnNames in PageSourceProvider, toImmutableSet, remove Collectors import - prestodb#4: Replace ArrayList with ImmutableList.Builder throughout - prestodb#8: Update test to expect parenthesized range expressions - Add missing tests: TimestampType, RealType, valuesNone+notNullable
jja725
added a commit
that referenced
this pull request
Mar 30, 2026
- #1: getLatestVersion now uses cache instead of opening throwaway Dataset - #2: Add bounds check for version > Integer.MAX_VALUE before intValue() - #3: Add thread-safety documentation for cached Dataset objects - prestodb#4: Add requireNonNull for tablePath and namespaceHolder in FragmentScannerFactory - prestodb#5: Remove dead code openDatasetDirect() - prestodb#6: Remove dead code getOptionalDatasetVersion() - prestodb#7: Remove premature userIdentity parameter from cache key - prestodb#8: Make getReadOptions() private (only used internally) - prestodb#9: Tests now use versioned table handle from getTableHandle() - prestodb#10: Add @AfterMethod with namespaceHolder.shutdown() to prevent resource leaks - prestodb#12: Use explicit invalidateAll(keys) instead of removeIf on asMap()
jja725
added a commit
that referenced
this pull request
Mar 30, 2026
- #1: Add javadoc noting eventual consistency contract for getLatestVersion - prestodb#4: Fix RST table column alignment for cache properties - prestodb#5: Use toImmutableList() instead of Collectors.toList() per Presto convention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: