lib: replace protobuf crate with prost #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralith
force-pushed
the
push-568edbae42a84d8fbe03433e17e0fe46
branch
2 times, most recently
from
8fd0841 to
590353c
Compare
Ralith
force-pushed
the
push-568edbae42a84d8fbe03433e17e0fe46
branch
17 times, most recently
from
1d3dcd4 to
cb5ff46
Compare
|
This now also switches to manually-generated code (via |
Nice! Thanks for setting that up. |
martinvonz
reviewed
Dec 22, 2022
Ralith
force-pushed
the
push-568edbae42a84d8fbe03433e17e0fe46
branch
4 times, most recently
from
570d5d3 to
aba6659
Compare
Ralith
force-pushed
the
push-568edbae42a84d8fbe03433e17e0fe46
branch
from
aba6659 to
182b5a4
Compare
martinvonz
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prost is a far more conformant implementation (stepancheg/rust-protobuf#661 vs. https://github.com/tokio-rs/prost/blob/master/conformance/failing_tests.txt) and appears to be more actively maintained (no commits in protobuf since September, PRs not being reviewed).
Checklist
If applicable:
CHANGELOG.md