Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown cleanup (bookmarks.md, contributing.md) #4927

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jabielecki
Copy link

Previous markdown did not produce any appealing effect on github.com renderer.
Change markdown to the style supported by github.com.

The notes were of varying importance. Using a quotation-style note where the distraction is not warranted.

Use "[!TIP]" formatting per Github formatting recommendation.

Previous markdown did not produce any appealing effect on Github renderer. This change formats a quotation-style note - probably less distracting.
Copy link

google-cla bot commented Nov 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ilyagr
Copy link
Contributor

ilyagr commented Nov 20, 2024

We can't really review this until you sign the CLA.

Also, we just simplified previewing the website on your machine. Can you follow https://martinvonz.github.io/jj/prerelease/contributing/#previewing-the-html-documentation and double-check that your changes don't make the website look worse?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants