Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base/ui): update tokens #15688

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(base/ui): update tokens #15688

wants to merge 2 commits into from
+235 −55

Conversation

Calinteodor
Copy link
Contributor

No description provided.

@Calinteodor Calinteodor marked this pull request as draft March 3, 2025 10:27
saghul
saghul requested changes Mar 4, 2025
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. New plan:

  • the JSON theme becomes "tokens"
  • the colorMap can only map to tokens
  • if we need extra tokens we'll have some 'jitsiTokens' extra
  • no need to pass colors around, just build the palette

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Calinteodor @saghul