Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to room name #5739

Closed
guerda opened this issue Apr 7, 2020 · 9 comments
Closed

Add label to room name #5739

guerda opened this issue Apr 7, 2020 · 9 comments
Labels
accessibility Issue related to accessibility topics/handicapped users wontfix Issue won't be fixed

Comments

@guerda
Copy link

guerda commented Apr 7, 2020

Is your feature request related to a problem you are facing?
Based on the discussion at https://community.jitsi.org/t/accessibility-ranking-of-jitsi/27796, I would like to see a label for the room name, in order to help users to identify what the input field is

Describe the solution you'd like
Add a before the input field.

I will add a pull request for this.

guerda added a commit to guerda/jitsi-meet that referenced this issue Apr 7, 2020
Improve accessibility, see jitsi#5739
@Echolon
Copy link

Echolon commented May 13, 2020

@guerda can you connect the related issue with this PR?

@l3d00m l3d00m added the accessibility Issue related to accessibility topics/handicapped users label May 16, 2020
@guerda
Copy link
Author

guerda commented May 18, 2020

@Echolon I'm not sure how to do that, but I'm happy to learn. Should I just mention the PR in this issue here?

@Echolon
Copy link

Echolon commented May 18, 2020

@guerda its not complicated. Just go to the referenced PR, and on the right side you can "Link to relevant issue" or something like this.

@luixxiul
Copy link
Contributor

Maybe it means: By adding Close #5739 inside the first post of the PR / inside the commit message, this issue will be closed automatically when the PR is merged.

@guerda
Copy link
Author

guerda commented May 18, 2020

Thanks @luixxiul ! I was able to add it as a linked issue via your hint. @Echolon : done :)

@DJCrashdummy
Copy link

this is at least related to #5169...

@stale
Copy link

stale bot commented Sep 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Sep 29, 2020
@guerda
Copy link
Author

guerda commented Oct 4, 2020

As soon as #5740 is approved, this can be merged. Still waiting for the review.

@stale stale bot removed the wontfix Issue won't be fixed label Oct 4, 2020
@stale
Copy link

stale bot commented Jan 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issue won't be fixed label Jan 3, 2021
@stale stale bot closed this as completed Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility topics/handicapped users wontfix Issue won't be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants