Skip to content

Commit

Permalink
Revert "external_api: fixed using deeplinks"
Browse files Browse the repository at this point in the history
This breaks the mobile deeplinking page
This reverts commit 532dadb.
  • Loading branch information
jallamsetty1 committed May 19, 2020
1 parent fa43539 commit 5591144
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ class DeepLinkingMobilePage extends Component<Props> {
<button className = { downloadButtonClassName }>
{ t(`${_TNS}.downloadApp`) }
</button>
target = '_top'
</a>
<a
{ ...onOpenLinkProperties }
Expand All @@ -139,7 +138,6 @@ class DeepLinkingMobilePage extends Component<Props> {
{/* <button className = { `${_SNS}__button` }> */}
{ t(`${_TNS}.openApp`) }
{/* </button> */}
target = '_top'
</a>
{ renderPromotionalFooter() }
<DialInSummary
Expand Down

2 comments on commit 5591144

@msalmasi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? This has fixed the issue of deeplinking from within an iFrame for multiple people, and has not otherwise broken deeplinking for anyone. There is no reason why this should affect anything other than deeplinking from within an iframe.

@jallamsetty1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? This has fixed the issue of deeplinking from within an iFrame for multiple people, and has not otherwise broken deeplinking for anyone. There is no reason why this should affect anything other than deeplinking from within an iframe.

We were getting ready for a release and noticed this so had to quickly revert to proceed with the release.
Image from iOS

Please sign in to comment.