Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing Jitsi Meet #369

Closed
maddie-wang opened this issue May 28, 2020 · 3 comments · Fixed by #377
Closed

Signing Jitsi Meet #369

maddie-wang opened this issue May 28, 2020 · 3 comments · Fixed by #377

Comments

@maddie-wang
Copy link

Hello! I bought an Apple Developer account and I have the developer certificates installed on my computer.

I am having trouble running 'npm run dist' on Jitsi Meet. Electron-builder automatically detected my certificates and started to sign it. However.... this occurred:

 • packaging       platform=darwin arch=x64 electron=9.0.0 appOutDir=dist/mac
  • downloading     url=https://github.com/electron/electron/releases/download/v9.0.0/electron-v9.0.0-darwin-x64.zip size=73 MB parts=8
  • downloaded      url=https://github.com/electron/electron/releases/download/v9.0.0/electron-v9.0.0-darwin-x64.zip duration=35.845s
  • signing         file=dist/mac/Jitsi Meet.app identityName=Developer ID Application: Madison Wang (4MP829ALF6) identityHash=AB3B90EFED7B0947C2CD305DE9AC1C0098F2B50D provisioningProfile=none
  ⨯ Command failed: codesign --sign AB3B90EFED7B0947C2CD305DE9AC1C0098F2B50D --force --options runtime --entitlements entitlements.mac.plist /Users/mac/Documents/jitsi-meet-electron/dist/mac/Jitsi Meet.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework
/Users/mac/Documents/jitsi-meet-electron/dist/mac/Jitsi Meet.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework: code object is not signed at all
In subcomponent: /Users/mac/Documents/jitsi-meet-electron/dist/mac/Jitsi Meet.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Helpers/chrome_crashpad_handler
  stackTrace=
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 Error: Command failed: codesign --sign AB3B90EFED7B0947C2CD305DE9AC1C0098F2B50D --force --options runtime --entitlements entitlements.mac.plist /Users/mac/Documents/jitsi-meet-electron/dist/mac/Jitsi Meet.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 /Users/mac/Documents/jitsi-meet-electron/dist/mac/Jitsi Meet.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework: code object is not signed at all
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 In subcomponent: /Users/mac/Documents/jitsi-meet-electron/dist/mac/Jitsi Meet.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Helpers/chrome_crashpad_handler
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     at ChildProcess.exithandler (child_process.js:295:12)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     at ChildProcess.emit (events.js:210:5)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     at maybeClose (internal/child_process.js:1021:16)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 From previous event:
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     at module.exports.execFileAsync (/Users/mac/Documents/jitsi-meet-electron/node_modules/app-builder-lib/electron-osx-sign/util.js:41:10)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     at /Users/mac/Documents/jitsi-meet-electron/node_modules/app-builder-lib/electron-osx-sign/sign.js:172:17
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 From previous event:
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     at signApplicationAsync (/Users/mac/Documents/jitsi-meet-electron/node_modules/app-builder-lib/electron-osx-sign/sign.js:127:6)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     at /Users/mac/Documents/jitsi-meet-electron/node_modules/app-builder-lib/electron-osx-sign/sign.js:338:14
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     at processTicksAndRejections (internal/process/task_queues.js:93:5)
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                     at MacPackager.sign (/Users/mac/Documents/jitsi-meet-electron/node_modules/app-builder-lib/src/macPackager.ts:202:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] dist: `npm run build && electron-builder`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] dist script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@maddie-wang
Copy link
Author

@saghul

@saghul
Copy link
Member

saghul commented Jun 2, 2020

That should've worked. @awlx I think you have been tinkering with signing recently, maybe you know?

@awlx
Copy link
Contributor

awlx commented Jun 2, 2020

So this an error currently in the electro-sign-osx code. As it needs --deep for codesign. It will be fixed upstream soon.

Meanwhile you can patch it manually.
electron-userland/electron-builder#1546 (comment)

Edit:
Oh, it seems to be merged now. Might need a bump of electron-builder:
https://github.com/electron-userland/electron-builder/pull/4993/files

Edit2:
Opened PR @saghul

awlx pushed a commit to awlx/jitsi-meet-electron that referenced this issue Jun 2, 2020
@awlx awlx mentioned this issue Jun 2, 2020
saghul pushed a commit that referenced this issue Jun 2, 2020
d3473r pushed a commit to d3473r/jitsi-meet-electron that referenced this issue Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants