Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Upgrade Guzzle to ~6.0 #3

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Upgrade Guzzle to ~6.0 #3

merged 1 commit into from
Dec 12, 2016

Conversation

stevenscg
Copy link
Contributor

This PR upgrades the SDK to use Guzzle 6.

I am still exercising these changes with functionality very similar to the examples (shell.php and task.php), hence the "hold" designation for now.

I am curious how others are using this SDK now or would like to in the future.

My initial use case is seeding vaults in developer and CI environments with secrets similar to the deployed environments.

This will likely be a small standalone application and/or repository (vs being called within another app). Vault is already installed, configured, and running on the host via configuration management tool.

The examples already in the project do this vault seeding sequence very well for CakePHP apps, but I think there is an opportunity to implement some of this logic on a Jippi\Vault\Helper namespace very similar to the Consul SDK and be usable within any app or framework.

A "Seed" helper with some convenience methods fits my current use case well:

        $this->reset();

        $this->create();
        $this->unseal();

        $this->Vault->waitFor(['sealed' => false, 'standby' => false]);
        $this->Vault->clear();

        $this->mounts();

But there may be a better name or context than "seed" from which to offer these methods.

@nerdstein
Copy link

I would love to see this get merged as I am building the Drupal contributed module that connects with Vault. My use case is quite similar to that which is in the examples, but Drupal is running Guzzle 6.2.2 and I won't be able to load the SDK until this gets merged.

@jippi
Copy link
Owner

jippi commented Dec 12, 2016

Hi

I'm not sure why it was on HOLD tbh, i think it should be merged in unless someone got a good reason for it not to be? :)

@nerdstein
Copy link

@jippi --- I totally agree. Guzzle 6 has been out a while. It would be super helpful to get this merged in.

@jippi jippi merged commit 97dba9b into jippi:master Dec 12, 2016
@jippi
Copy link
Owner

jippi commented Dec 12, 2016

@nerdstein
Copy link

Wow, thank you for doing this so promptly!

@stevenscg
Copy link
Contributor Author

@jippi @nerdstein I had a particular use case that dried up as I was finishing this out, so put it on hold until jippi or I could exercise it a bit. We are still using Vault (and Consul and Nomad, etc), so I expect to get back to using this SDK shortly.

I think the cake tasks might still need to be converted.

@stevenscg stevenscg deleted the cs-guzzle6 branch December 12, 2016 15:16
@nerdstein
Copy link

This makes sense...

@stevenscg stevenscg changed the title [HOLD] Upgrade Guzzle to ~6.0 Upgrade Guzzle to ~6.0 Dec 12, 2016
@zerowebcorp zerowebcorp mentioned this pull request Dec 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants