Mixpanel integration and tests added #51
Conversation
A few things to notice: * The Mixpanel-api uses GET for everything and it's over unencryptet http * Events older than 5 years will fail to import (this isn't supported * by the api) * The api is documented here: https://mixpanel.com/help/reference/http
|
So any progress on this? No rush though :) |
|
I've been swamped over recently, planning on doing the review shortly, though! :) |
|
Bump 😀 Did you get around to review this? |
|
It's a shame, I didn't look at it yet :( I'll look at it really soon! I can't this week, but snoozing it for a few days. Hopefully I can take the time over the weekend or next week. Really sorry about that man! |
|
Wow, Mixpanel over HTTP not HTTPS? It seems to be documented like that indeed. I found that, though: https://mixpanel.com/help/questions/articles/how-can-i-send-data-to-mixpanel-over-https-instead-of-http-using-the-javascript-library - do you think it would work in our case too? Otherwise, that's pretty worrying to send data to Mixpanel :/ |
| } | ||
|
|
||
| func token() string { | ||
| return os.Getenv("MIXPANEL_TOKEN") | ||
| } | ||
|
|
||
| func init() { | ||
| integrations.RegisterIntegration("mixpanel", Mixpanel{}) | ||
| mixpanel := Mixpanel{} | ||
| mixpanel.api = &mixpanelAPIProduction{Url: "http://api.mixpanel.com/"} |
There was a problem hiding this comment.
Did you try HTTPS like suggested in https://mixpanel.com/help/questions/articles/how-can-i-send-data-to-mixpanel-over-https-instead-of-http-using-the-javascript-library ? Worth trying IMHO as HTTP is worrying for that kind of event :/
|
It’s a while since I looked at this, so it might be they have added https-support after my PR. I’ll have a look and see if it’s supported. Sending analytics data unencrypted is indeed a bad idea 🙂 |
|
Looks like the mixpanel api might have changed since this PR was submitted, so i might need to re-submit a new PR that supports the new api. Is support for mixpanel still needed? If so I can look into supporting the new api. This isn't the end of the world as the previous api was pretty bad :) |
|
Nah, I already feel bad for not merging this earlier. Unless you need it yourself, feel free to ignore! 😀 |
|
Ok, we'll disregard this PR then, closing it now :) |
A few things to notice:
I made everything behave as consistently with the other integrations as possible in spite of the kinda strange Mixpanel-api. Tell me what you think, and I'll fix any issues that pops up 😃