Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backwards-compatibility with legacy separators in order_by clauses #715

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Fix backwards-compatibility with legacy separators in order_by clauses #715

merged 2 commits into from
Nov 20, 2019

Conversation

federicobond
Copy link
Contributor

Fixes #714

@federicobond
Replace assertWarns with assertWarnsRegex in test_utils.py
f2f14a3 
The msg keyword that was being used before does not check the
actual warning message, but rather configures the test assertion
error message.
@jieter
Copy link
Owner

jieter commented Nov 20, 2019

@federicobond thanks!

@jieter jieter merged commit f73812c into jieter:master Nov 20, 2019
@federicobond federicobond deleted the fix-backwards-compatibility branch November 20, 2019 11:53
@jieter
Copy link
Owner

jieter commented Nov 21, 2019

released 2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing FROM-clause entry for table when using deprecated dot accessors
2 participants
@federicobond @jieter