Fixed #408 - used remote_field instead of deprecated rel #409
Conversation
| @@ -1,2 +1,2 @@ | |||
| -r common.pip | |||
| http://github.com/django/django/tarball/master | |||
| https://github.com/django/django/archive/1.11a1.zip | |||
There was a problem hiding this comment.
Is this intentional? Because this will not continue to be the django development version.
There was a problem hiding this comment.
Yes, this is intentional.
In tox.ini in section [testenv:docs] are installed requirements from /requirements/common.pip and now is not working for master because, currently master is a Django 2.0.
Section for documentation must be tested with python 2.7 and Django < 2.0.
I think that requirements/django-dev.pip and tests for documentation must be changed in future.
Maybe you have any suggestions how to change it?
| rel = getattr(field, 'remote_field', None) | ||
| model = getattr(rel, 'model', model) | ||
| else: | ||
| # Since django 1.9 `rel` attribute was replaced by `remote_field` |
There was a problem hiding this comment.
Can you change this comment in such a way that when we remove support for the last version this shim is intended for we only have to look for the version number we are removing support for?
|
Thanks for the pull, looks good. I tried doing it by testing for |
|
I also cleaned tox.ini and travis.yml files because there was few mistakes. |
|
Merged, thanks! |
|
released 1.3.0 |
…r#409) * Fixed jieter#408 - used remote_field instead of deprecated rel * Changed comment for solution issues 408
No description provided.