forloop.counter not render in Django1.10 for TemplateColumn

[djk2]

django-tables2==1.0.4

class SomeTable(tables.Table):
    action = TemplateColumn("{{ forloop.counter }}")

for Django 1.9.13 it works fine.
for Django 1.10 forloop not exist in table.context and not rendered correctly

Have you any idea?
I spent on this problem 8 hours trying solve it.

[jieter]

so with the exact same version of django-tables2, different django versions show this behaviour?

[djk2]

Exactly, different django versions show this behaviour.

[jieter]

can you maybe supply a simple test case?

[djk2]

I will prepare unit test today evening.

[djk2]

For current master I can't reproduce this error.
Templatetag forloop.counter is never render in TemplateColumn.
I tested for all supported Django versions and current DjT2 can't render forloop. In past that feature works fine.
This was very helpfull for generate css ids for JS.

[jieter]

I think it makes sense to add a context variable containing a counter without counting on the template context leaking through... What do you think?

If you have time, feel free to open a PR.

[jieter]

As of version 1.14.2, a template variable row_counter is available.

class CountryTable(tables.Table):
        counter = tables.TemplateColumn('{{ row_counter }}', verbose_name='#')

1.14.2 is released.

[waketzheng]

Now that row_counter is start from 0, if I want to start from 1, how to do it?

[jieter]

You can use the add template filter: https://docs.djangoproject.com/en/2.0/ref/templates/builtins/#add

[djk2]

class CountryTable(tables.Table):
        counter = tables.TemplateColumn('{{ row_counter|add:1 }}', verbose_name='#')