Skip to content

Commit

Permalink
add missing check to dashboard-ingress (helm chart) (apache#6160)
Browse files Browse the repository at this point in the history
### Motivation

if you deploy pulsar using the helm chart and disable monitoring with

```
extras:
  dashboard: no

```

but you have the ingress of the dashboard set to true

```
dashboard:
  ingress:
    enabled: true
```

the helm chart will create an ingress that points to a non-existing service because the dashboard itself was not deployed.

### Modifications

I've added the same check that is already in place in dashboard-service and dashboard-deployment

### Verifying this change

I dont know of any automated tests, i tested it manually. In the end it's the same "if" that is already in place in dashboard-service and dashboard-deployment

### Does this pull request potentially affect one of the following parts:

Affects deployment via helm chart. An unwanted ingress object is suppressed.

### Documentation

 no documentation need

(cherry picked from commit efee516)
  • Loading branch information
tmemenga authored and jiazhai committed May 17, 2020
1 parent 6250567 commit e650f9e
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
# under the License.
#

{{- if .Values.extra.dashboard }}
{{- if .Values.dashboard.ingress.enabled }}
apiVersion: extensions/v1beta1
kind: Ingress
Expand Down Expand Up @@ -51,3 +52,4 @@ spec:
serviceName: "{{ template "pulsar.fullname" . }}-{{ .Values.dashboard.component }}"
servicePort: {{ .Values.dashboard.ingress.port }}
{{- end }}
{{- end }}

0 comments on commit e650f9e

Please sign in to comment.