Only match ASCII letters and digits #2312
Merged
+97
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Cool beans. Could you add a couple positive / negative tests for these, in StringUtils? So that nobody gets a rush of blood to their head and tries to tidy it up back to Character.isLetter. |
cketti
force-pushed
the
ascii-only-matching
branch
from
d776a7b to
1d4772d
Compare
Contributor
Author
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace calls to
java.lang.Character.isLetter()andisDigit(). In all these cases we really only want to allow ASCII letters or digits.