Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile #74

Closed
wants to merge 54 commits into from
Closed

Add dockerfile #74

wants to merge 54 commits into from

Conversation

derekbelrose
Copy link

This implements a Dockerfile and CI that will push to the registry during a merge to master event in GitHub.

Copy link
Collaborator

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only suggestion is to add a section to the README for building a production image.

@derekbelrose
Copy link
Author

This is going to be refactored a bit. The CI setup took me in a different direction.

@derekbelrose derekbelrose marked this pull request as draft June 9, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants