sass support for bootstrap 4 and font-awesome #4630
Conversation
| @@ -40,8 +40,19 @@ const files = { | |||
| sass: [ | |||
| { | |||
| condition: generator => generator.useSass, | |||
| templates: [ | |||
| '_.bootstraprc', | |||
There was a problem hiding this comment.
what does these files do? could you please explain
There was a problem hiding this comment.
I use the bootstrap-loader. I follow the instructions described here: https://github.com/shakacode/bootstrap-loader.
The file .bootstraprc describes the sass configuration needed: preBootstrapCustomizations, bootstrapCustomizations, appStyles files. The preBootstrapCustomizations contains values-variables that bootstrap will use such as $input-color: $gray !default;. Is this the scope of the vendor file?
Second file: font-awesome-sass-loader. This package needs configuration with the sass file prefilled and some rules.
| import '../content/css/main.css'; | ||
| <%_ if(useSass) { _%> | ||
| import '../content/css/vendor.css'; | ||
| // import '../content/css/vendor.css'; deprecated??? |
There was a problem hiding this comment.
The vendor.css is not generated. .
| "window.jQuery": "jquery", | ||
| 'Tether': 'tether', | ||
| 'window.Tether': 'tether', | ||
| Tooltip: "exports?Tooltip!bootstrap/js/dist/tooltip", |
There was a problem hiding this comment.
we dont need any bootstrap JS stuff. We use only css from here. For js we use ng-bootstrap
There was a problem hiding this comment.
This configuration is needed because of the issue shakacode/bootstrap-loader#172. If I didn't include these changes, I should comment the bootstrap scripts from the _.bootstraprc file.
|
I think this solution is too complicated. I will leave bootstrap-loader. I don't close the pull request as I will commit a new fix until end of day. |
|
yes I dont see why we need bootstrap loader anyway :P
Thanks & Regards,
Deepu
…On Fri, Dec 9, 2016 at 3:42 PM, dimeros ***@***.***> wrote:
It is too complicated. I will leave bootstrap-loader. I don't close the
pull request as I will commit a new fix until end of day.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4630 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDlF2vwl1j8Pp52LijsBVL1qZqGXSBNks5rGWjhgaJpZM4LHrI5>
.
|
|
Please open a new PR to the master branch |
Sass support for bootstrap 4 and font-awesome in angular-2.