Evict user login cache for couchbase #28039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielFran
changed the title
mshima
reviewed
Nov 30, 2024
There was a problem hiding this comment.
This indeed fixes the issue: https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/12099821193.
But I don’t this is the correct fix since the caching evict is done selectively in clearUserCache method.
The annotation will evict the entire cache.
I think this is a test only issue due to some test bypassing UserService (direct repository usage) and not correctly evicting.
|
Sorry, I forgot about key, updated :) |
DanielFran
approved these changes
Dec 1, 2024
|
Thanks @kamilkrzywanski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix all tests from daily builds should be green :)
#27490