Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Spring Boot to v3.3.5 #27677

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Update Spring Boot to v3.3.5 #27677

merged 3 commits into from
Oct 26, 2024

Conversation

github-actions[bot]
Copy link
Contributor

update spring-boot-dependencies bom to v3.3.5

@github-actions github-actions bot added the theme: dependencies Pull requests that update a dependency file label Oct 24, 2024
@mshima mshima marked this pull request as draft October 24, 2024 13:56
@mshima mshima closed this Oct 24, 2024
@mshima mshima reopened this Oct 24, 2024
@DanielFran
Copy link
Member

📊 SonarQube Analysis for ng-default

Metric Value
New Vulnerabilities 0
New Bugs 0
New Code smells 0
Coverage on New Code N/A%
Duplication on New Code N/A%

DanielFran
DanielFran previously requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@DanielFran DanielFran left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add back couchmove
See #27563

generators/spring-boot/resources/spring-boot-dependencies.pom Show resolved Hide resolved
generators/spring-boot/resources/spring-boot-dependencies.pom Show resolved Hide resolved
@mshima
Copy link
Member

mshima commented Oct 24, 2024

Add back couchmove See #27563

I didn’t realized it was added to the spring-boot pom.
It should be added to dependabot instead.

@mraible
Copy link
Contributor

mraible commented Oct 24, 2024

FYI... from https://twitter.com/sdeleuze/status/1849489721556418920

If you are using r2dbc, I strongly recommend upgrading to Spring Boot 3.3.5 which contains an amazing optimization crafted by mp911de and chemicL which provides a huge performance boost (higher thoughput, lower latency) under high concurrency.

I removed @ from the tweet above so no one is tagged.

@mshima
Copy link
Member

mshima commented Oct 24, 2024

I think CI is failing due to spring-cloud/spring-cloud-gateway#3568.
There is not exception in logs.

@mraible
Copy link
Contributor

mraible commented Oct 26, 2024

See #27690 for a possible workaround.

@mshima mshima changed the title update spring-boot-dependencies bom to v3.3.5 Update Spring Boot to v3.3.5 Oct 26, 2024
@mshima mshima marked this pull request as ready for review October 26, 2024 17:47
@mshima
Copy link
Member

mshima commented Oct 26, 2024

Couchmove will be correctly added here #27692.

@DanielFran DanielFran merged commit 64463e3 into main Oct 26, 2024
65 checks passed
@DanielFran DanielFran deleted the spring-boot/v3.3.5 branch October 26, 2024 19:13
@mraible mraible added this to the 8.7.2 milestone Oct 28, 2024
@mshima mshima mentioned this pull request Nov 21, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshima mshima mshima left review comments

@DanielFran DanielFran DanielFran approved these changes

Assignees
No one assigned
Labels
theme: dependencies Pull requests that update a dependency file theme: java
Projects
None yet
Milestone
8.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielFran @mshima @mraible