Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ModifyServersOpenApiFilter with ServerBaseUrlCustomizer #26706

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

mshima
Copy link
Member

@mshima mshima commented Jul 12, 2024

Related to #25715.

It's not possible to modify a microservice response in imperative gateway.
So springdoc/springdoc-openapi#2589 was implemented to generate the openapi url correctly without having to change in gateway.

This PR replaces the response customization with a SpringDoc config that generates the url correctly based on Gateway passed headers.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit 5059d28 into jhipster:main Jul 12, 2024
52 checks passed
@github-actions github-actions bot deleted the openapi branch July 12, 2024 16:27
@mraible mraible added this to the 8.7.0 milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants