Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid filtering out relationships where entities support filtering #26357

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

OmarHawk
Copy link
Contributor

@OmarHawk OmarHawk commented Jun 4, 2024

Fix #26356


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@OmarHawk
Copy link
Contributor Author

OmarHawk commented Jun 4, 2024

This is for discussion whether it makes sense to limit this change to Angular only or to some other condition or to pass again the relationship kind of unfiltered to each kind of client.

My Opinion: Why would we want to limit what the client code does with the relationships, i.e. why should it be filtered out so early? So I think, my approach is alright.

@OmarHawk OmarHawk marked this pull request as ready for review June 4, 2024 18:07
@OmarHawk OmarHawk force-pushed the bugfix/unfiltered-relationshiplist branch from 09ef339 to b88fd8c Compare June 5, 2024 06:41
@OmarHawk OmarHawk changed the title Remove invalid filters on relationships for clients Avoid filtering out relationships where entities support filtering Jun 5, 2024
@OmarHawk OmarHawk force-pushed the bugfix/unfiltered-relationshiplist branch from b88fd8c to 787b397 Compare June 5, 2024 06:46
@OmarHawk OmarHawk requested a review from mshima June 5, 2024 09:44
@OmarHawk OmarHawk force-pushed the bugfix/unfiltered-relationshiplist branch from 787b397 to 9978f7f Compare June 6, 2024 06:44
@mshima mshima merged commit 7a4d260 into jhipster:main Jun 6, 2024
52 checks passed
@mraible mraible added this to the 8.6.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular: Quick Filter buttons are not generated anymore
3 participants